Skip to content

[Custom Logs] Implement input parameter exclude_files #7940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

EmiBruno
Copy link
Contributor

@EmiBruno EmiBruno commented Sep 22, 2023

  • Enhancement

What does this PR do?

Expose exclude_files option for the Custom Logs integration.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Build package and startup test environment:
cd package/log
elastic-package build
elastic-package stack up -v -d
  1. Add a new "Custom Logs" integration to a policy
  2. Verify if the correct logs are collected by the datastream

Related issues

Screenshots

image

image

@EmiBruno EmiBruno marked this pull request as ready for review September 22, 2023 11:14
@EmiBruno EmiBruno requested a review from a team as a code owner September 22, 2023 11:14
@EmiBruno EmiBruno requested review from belimawr and rdner September 22, 2023 11:14
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T12:22:57.385+0000

  • Duration: 14 min 12 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@cmacknz cmacknz added the Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent] label Sep 22, 2023
@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@rdner
Copy link
Member

rdner commented Sep 25, 2023

Could you please attach a screenshot of the configuration page for this new value. Should be a part of the PR description.

@EmiBruno
Copy link
Contributor Author

Could you please attach a screenshot of the configuration page for this new value. Should be a part of the PR description.

@rdner I uploaded the screenshots in the PR description.

@rdner rdner merged commit 0a08368 into elastic:main Sep 25, 2023
@elasticmachine
Copy link

Package log - 2.3.0 containing this change is available at https://epr.elastic.co/search?package=log

@andrewkroh andrewkroh added the Integration:log Custom Logs (Deprecated) label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:log Custom Logs (Deprecated) Team:Elastic-Agent Platform - Ingest - Agent [elastic/elastic-agent]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Custom Logs] Implement input parameter exclude_files
5 participants