Skip to content

[Azure] Update null checks and if checks in the rename processor #7953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

ishleenk17
Copy link
Member

  • Bug

What does this PR do?

This PR adds the if check for event.original and the ignore_missing check for the renaming of message to event.original
The packages where the changes are made are as below:

  • azure_frontdoor

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

elasticmachine commented Sep 25, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-25T05:59:43.518+0000

  • Duration: 13 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 91.667% (22/24) 👍 3.841
Lines 100.0% (290/290) 💚 3.987
Conditionals 100.0% (0/0) 💚

@ishleenk17 ishleenk17 marked this pull request as ready for review September 25, 2023 07:56
@ishleenk17 ishleenk17 requested a review from a team as a code owner September 25, 2023 07:56
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@elasticmachine
Copy link

Package azure_frontdoor - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=azure_frontdoor

@andrewkroh andrewkroh added the Integration:azure_frontdoor Azure Frontdoor (Community supported) label Jul 22, 2024
@ishleenk17 ishleenk17 deleted the azure_event_otriginal branch February 7, 2025 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:azure_frontdoor Azure Frontdoor (Community supported)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants