Skip to content

[O11y][Apache Spark] Add dimension mapping for application datastream #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

harnish-crest-data
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds dimension fields for application data stream to support TSDB enablement.

Checklist

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T10:13:56.149+0000

  • Duration: 20 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Sep 27, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (12/16)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@harnish-crest-data harnish-crest-data marked this pull request as ready for review September 29, 2023 05:45
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner September 29, 2023 05:45
agithomas
agithomas previously approved these changes Oct 5, 2023
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

@harnish-elastic , please complete the peer review additionally.

@agithomas agithomas dismissed their stale review October 5, 2023 05:58

Errors identified

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into apache_spark-application-add-dimension

Conflicts:
	packages/apache_spark/changelog.yml
	packages/apache_spark/manifest.yml
@harnish-crest-data harnish-crest-data merged commit 92265bc into elastic:main Oct 12, 2023
@elasticmachine
Copy link

Package apache_spark - 0.7.0 containing this change is available at https://epr.elastic.co/search?package=apache_spark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants