-
Notifications
You must be signed in to change notification settings - Fork 474
Infoblox_nios: add client geoip and registered_domain processors to dns data #8107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🌐 Coverage report
|
packages/infoblox_nios/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/infoblox_nios/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
packages/infoblox_nios/data_stream/log/elasticsearch/ingest_pipeline/pipeline_dns.yml
Outdated
Show resolved
Hide resolved
…peline/default.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…peline/default.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…peline/pipeline_dns.yml Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@efd6 did remove the non ecs conforming fields. Does the rest look good? |
Is there a reason not to include the flags as the ECS-compliant field? |
The |
🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the proposed commit message to match the current state of the change. Otherwise LGTM.
Can you take care of it please? I am out on PTO for another full week :) |
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Package infoblox_nios - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_nios |
When looking at the differences between the infoblox NIOS DNS dataset and our
network_packet_capture
dataset I discovered that we are not usingdns.flags
to print out the DNS flags such as:Taken from: Infoblox DNS
This is an example taken from our
network packet capture dns
dataset:I added the following:
couple ofset
processors to add the flagsclient.ip
.I am not sure about the version bump, if this should become 1.17.0 or 2.0.0.
Proposed commit message
This adds a
geoip
processor for theclient.ip
field and aregistered_domain
processor for thedns.question.name
field.Checklist
changelog.yml
file.