Skip to content

[Lateral Movement Detection] Update files to add Serverless support to the package #8121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Oct 16, 2023

Conversation

sodhikirti07
Copy link
Contributor

@sodhikirti07 sodhikirti07 commented Oct 6, 2023

What does this PR do?

This PR adds serverless support to the Lateral Movement Detection advanced analytics package.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

  • Follow the steps to spin a Serverless project using elastic-package
  • Make sure the format spec for manifest.yml is 3.0.0
  • Test if all the assets i.e. pivot transform, anomaly detection jobs, detection rules and dashboard are getting installed successfully.

Screenshots

  • Package Installation:
    image

  • Pivot transform is getting started:
    image

  • Destination index fields are mapped correctly:

image
  • Anomaly detection jobs installed and started:
    image

image

  • Security rules are enabled:
    image

  • Dashboard is installed properly:
    image

@sodhikirti07 sodhikirti07 added the enhancement New feature or request label Oct 6, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-16T16:59:19.324+0000

  • Duration: 15 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@sodhikirti07 sodhikirti07 marked this pull request as ready for review October 6, 2023 14:41
@sodhikirti07 sodhikirti07 requested review from a team as code owners October 6, 2023 14:41
@qn895
Copy link
Member

qn895 commented Oct 6, 2023

Transform change LGTM 🎉

@@ -10,9 +10,12 @@ categories:
- security
- advanced_analytics_ueba
conditions:
kibana.version: "^8.8.0"
kibana:
version: '^8.8.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this minimum Stack version compatible with Package Spec v3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked with the serverless team and they confirm that we don't require a minimum Kibana version for serverless packages and they'll be based on spec versions. This condition is specifically kept for on-premise or stateful clusters.

sodhikirti07 and others added 4 commits October 6, 2023 11:35
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
….yml

Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
@sodhikirti07
Copy link
Contributor Author

/test

@@ -4,7 +4,7 @@ source:
bool:
must_not:
term:
user.name:
'user.name':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my own edification, what's this about?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nested fields are separated during elastic-package format which results in the below error. So, as per v3 spec, we'll need to surround the nested fields in quotes.

Error: error running package asset tests: could not complete test run: can't install the package: can't install the package: could not zip-install package; API status code = 500; response body = {"statusCode":500,"error":"Internal Server Error","message":"x_content_parse_exception\n\tCaused by:\n\t\tx_content_parse_exception: [1:404] [data_frame_config_source] failed to parse field [query]\n\tRoot causes:\n\t\tparsing_exception: [term] query does not support [name]"}

@sodhikirti07 sodhikirti07 merged commit 1f4cad9 into main Oct 16, 2023
@elasticmachine
Copy link

Package lmd - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=lmd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:lmd Lateral Movement Detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants