Skip to content

[GitHub] [Dependabot] event duration was in seconds, should be in nanos #8131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

philippkahr
Copy link
Contributor

@philippkahr philippkahr commented Oct 9, 2023

Hi,

according to our ECS documentation, event.duration is in nanoseconds. It was exposed as seconds.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@philippkahr philippkahr added the bugfix Pull request that fixes a bug issue label Oct 9, 2023
@philippkahr philippkahr requested a review from a team as a code owner October 9, 2023 07:19
@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-09T08:30:54.664+0000

  • Duration: 16 min 52 sec

Test stats 🧪

Test Results
Failed 0
Passed 34
Skipped 0
Total 34

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 9, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (5/5) 💚
Classes 100.0% (5/5) 💚
Methods 100.0% (66/66) 💚
Lines 94.123% (1041/1106) 👎 -0.692
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test expectation files.

@botelastic
Copy link

botelastic bot commented Nov 8, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the Stalled label Nov 8, 2023
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Stalled labels Nov 8, 2023
@botelastic botelastic bot removed the Stalled label Nov 8, 2023
@botelastic
Copy link

botelastic bot commented Dec 11, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 11, 2023
@mrodm
Copy link
Collaborator

mrodm commented Dec 21, 2023

Hi @philippkahr, please update your branch with the latest contents from main branch. There was an important PR merged updating the CI pipelines. Thanks!

@botelastic botelastic bot removed the Stalled label Dec 21, 2023
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 merged commit 0daff27 into elastic:main Dec 21, 2023
@elasticmachine
Copy link

Package github - 1.27.1 containing this change is available at https://epr.elastic.co/search?package=github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues bugfix Pull request that fixes a bug issue Integration:github GitHub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants