Skip to content

[LMD] Update unattended flag in LMD package #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

susan-shu-c
Copy link
Member

@susan-shu-c susan-shu-c commented Oct 27, 2023

Package spec reference

Proposed commit message

Update Lateral Movement Detection Package transform for Serverless

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Package Installation
Screenshot 2023-10-27 at 2 25 03 PM

Transform installation

@susan-shu-c susan-shu-c marked this pull request as ready for review October 27, 2023 16:14
@susan-shu-c susan-shu-c requested review from a team as code owners October 27, 2023 16:14
@elasticmachine
Copy link

elasticmachine commented Oct 27, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-27T19:40:37.786+0000

  • Duration: 15 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 1
Skipped 0
Total 1

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@pantea-elastic pantea-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qn895
Copy link
Member

qn895 commented Oct 27, 2023

LGTM 🎉

@susan-shu-c susan-shu-c changed the title Update unattended flag [lmd] Update unattended flag Oct 27, 2023
Copy link
Contributor

@sodhikirti07 sodhikirti07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@susan-shu-c
Copy link
Member Author

Thanks all for reviews! I've attached screenshots and tested, but @sodhikirti07 and I haven't been able to reproduce it when spinning up the stack again; the QA environment might have changed (or something) since Kirti mentions the DGA package that was fine last week can't be installed suddenly.

Will wait for next week to reproduce again and then merge! (But definitely it has worked earlier today)

@sodhikirti07
Copy link
Contributor

The transform is working and is able to collect the data in serverless (screenshot below). @susan-shu-c Think we're ready to merge the changes now!
image

@susan-shu-c
Copy link
Member Author

Thanks again @sodhikirti07 !

@susan-shu-c susan-shu-c merged commit adaabb0 into main Oct 30, 2023
@elasticmachine
Copy link

Package lmd - 2.1.1 containing this change is available at https://epr.elastic.co/search?package=lmd

@susan-shu-c susan-shu-c changed the title [lmd] Update unattended flag [LMD] Update unattended flag in LMD package Jan 9, 2024
@andrewkroh andrewkroh added the Integration:lmd Lateral Movement Detection label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:lmd Lateral Movement Detection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants