-
Notifications
You must be signed in to change notification settings - Fork 474
[AWS][Security Hub] Update Donut charts with Pie #8332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS][Security Hub] Update Donut charts with Pie #8332
Conversation
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval as codeowner.
On the basis that there is more room for labels in the pie chart this is a tenuous improvement, weighed against studies that have shown doughnut charts are marginally less deceptive than pie charts (as noted, neither should be used since humans are terrible at both angle comparison and relative areal assessment).
Ideally, we'd use something else.
Package aws - 2.8.5 containing this change is available at https://epr.elastic.co/search?package=aws |
What does this PR do?
Checklist
changelog.yml
file.Related issues
Screenshots
Before:

After:
