Skip to content

[AWS][Security Hub] Update Donut charts with Pie #8332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kush-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • In general pie/donut charts are not recommended for visualizing any data. Other options would be to use treemap instead where it's much easier to notice the real proportions of data. Or even instead of a donut, a pie chart can be used because there's more space for labels.
  • We have migrated AWS Security Hub Summary dashboard to use Pie Charts.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before:
image

After:
image

@kush-elastic kush-elastic self-assigned this Oct 30, 2023
@kush-elastic kush-elastic marked this pull request as ready for review October 30, 2023 12:12
@kush-elastic kush-elastic requested review from a team as code owners October 30, 2023 12:12
@kush-elastic kush-elastic added enhancement New feature or request Integration:aws AWS dashboard Relates to a Kibana dashboard bug, enhancement, or modification. labels Oct 30, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-30T12:12:50.566+0000

  • Duration: 64 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18)
Classes 94.444% (17/18)
Methods 86.047% (259/301)
Lines 86.083% (7571/8795)
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval as codeowner.

On the basis that there is more room for labels in the pie chart this is a tenuous improvement, weighed against studies that have shown doughnut charts are marginally less deceptive than pie charts (as noted, neither should be used since humans are terrible at both angle comparison and relative areal assessment).

Ideally, we'd use something else.

@kush-elastic kush-elastic merged commit 31ae0b3 into elastic:main Oct 31, 2023
@elasticmachine
Copy link

Package aws - 2.8.5 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard Relates to a Kibana dashboard bug, enhancement, or modification. enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AWS][Security Hub] Update donut charts with pie/treemap
6 participants