Skip to content

[O11y][Apache Tomcat] Update description in README.md #8394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2023
Merged

[O11y][Apache Tomcat] Update description in README.md #8394

merged 5 commits into from
Nov 7, 2023

Conversation

harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Nov 3, 2023 •
edited by shmsr
Loading

Proposed commit message

Update README with the latest version of Prometheus support and add a line in the troubleshooting section for Timezone.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-crest-data harnish-crest-data self-assigned this Nov 3, 2023
@harnish-crest-data harnish-crest-data marked this pull request as ready for review November 3, 2023 12:37
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner November 3, 2023 12:37
@elasticmachine
Copy link

elasticmachine commented Nov 3, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-06T09:59:21.310+0000

  • Duration: 25 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 3, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 97.531% (79/81) 👎 -2.469
Lines 82.393% (964/1170) 👎 -10.998
Conditionals 100.0% (0/0) 💚

ali786XI
ali786XI approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmsr shmsr added the enhancement New feature or request label Nov 3, 2023
shmsr
shmsr requested changes Nov 3, 2023
View reviewed changes
@shmsr shmsr changed the title [O11y][Apache Tomcat] Update descriptions in README.md [O11y][Apache Tomcat] Update description in README.md Nov 4, 2023
@harnish-crest-data @shmsr
Update packages/apache_tomcat/changelog.yml
ed2cb11 
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
shmsr
shmsr reviewed Nov 5, 2023
View reviewed changes
devamanv
devamanv approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest-data harnish-crest-data merged commit 5ea58db into elastic:main Nov 7, 2023
@elasticmachine
Copy link

Package apache_tomcat - 0.17.2 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devamanv devamanv devamanv approved these changes

@shmsr shmsr shmsr approved these changes

@ali786XI ali786XI ali786XI approved these changes

Assignees

@harnish-crest-data harnish-crest-data

Labels
enhancement New feature or request Integration:apache_tomcat Apache Tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harnish-crest-data @elasticmachine @devamanv @shmsr @ali786XI