Skip to content

[O11y][Microsoft SQL Server] Update the Transaction log dashboard #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ali786XI
Copy link
Contributor

Proposed commit message

This PR addresses the issues and enhancements described in the issue. Attaching the summary of the same here

  1. Updated the Rank By functionality to not use default values and instead use meaningful Rank by options
  2. Updated the Area Stacked chart type to Area only as it’s more understandable
  3. Legend gets truncated upon hovering the values hence not able to see at least the default database values. Hence updated the size to Large
  4. Colors used in the visualization are now changed to use Default value.
  5. Fixed the Percentage of Used Space [Metrics Microsoft SqlServer] visualization to show proper percentage values
  6. Enabled the Drop partial intervals toggle for all visualizations
  7. Added a Host Name control panel to filter the values of Hosts incoming
  8. Added a global data_stream.dataset filter

These visualizations were using Average aggregation instead of Last value hence updated the same.

  1. Percentage of Used Space [Metrics Microsoft SqlServer]
  2. Used Space [Metrics Microsoft SqlServer]
  3. Log Space Since Last Backup [Metrics Microsoft SqlServer]
  4. Recovery Size [Metrics Microsoft SqlServer]
  5. Log Size Since Last Checkpoint [Metrics Microsoft SqlServer]

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before
image

After
image

@ali786XI ali786XI added enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server labels Nov 14, 2023
@ali786XI ali786XI self-assigned this Nov 14, 2023
@ali786XI ali786XI requested a review from a team as a code owner November 14, 2023 13:04
@ali786XI ali786XI changed the title update the Transaction log dashboard [O11y][Microsoft SQL Server] Update the Transaction log dashboard Nov 14, 2023
@ali786XI
Copy link
Contributor Author

/test

1 similar comment
@ali786XI
Copy link
Contributor Author

/test

… into microsoft_sqlsrver_update_transactionlog_dashboard
@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-28T05:13:02.184+0000

  • Duration: 19 min 31 sec

Test stats 🧪

Test Results
Failed 0
Passed 19
Skipped 0
Total 19

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 15, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 93.75% (30/32) 👎 -4.526
Lines 100.0% (1252/1252) 💚 11.644
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar
Copy link
Contributor

LGTM!

… into microsoft_sqlsrver_update_transactionlog_dashboard
@ali786XI ali786XI merged commit fa9127d into elastic:main Nov 28, 2023
@elasticmachine
Copy link

Package microsoft_sqlserver - 2.4.0 containing this change is available at https://epr.elastic.co/search?package=microsoft_sqlserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:microsoft_sqlserver Microsoft SQL Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][Microsoft SQL Server] Issues and enhancements for [Metrics Microsoft SQL Server] Transaction log Dashboard
5 participants