auditd_manager: make socket type selection a set of options and correct documentation #8558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
…ct documentation The valid options for socket_type in auditbeat are unicast, multicast and '', checked during config validation, so provide a selection which maps 'auto' to ''. Unfortunately, we are not able to check that the combination of socket type and immutability are valid (this would require that we be able to compare a value in the template to 'multicast', but no comparison helpers exist in the handlbars instance used for integration config templates). The best we can do is tell users not to do this; it will show up in log failures.
efd6
force-pushed
the
8557-auditd_manager
branch
from
52dc349 to
be10bd4
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
|
Package auditd_manager - 1.16.1 containing this change is available at https://epr.elastic.co/search?package=auditd_manager |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The valid options for socket_type in auditbeat are unicast, multicast and '', checked during config validation, so provide a selection which maps 'auto' to ''.
Unfortunately, we are not able to check that the combination of socket type and immutability are valid (this would require that we be able to compare a value in the template to 'multicast', but no comparison helpers exist in the handlbars instance used for integration config templates). The best we can do is tell users not to do this; it will show up in log failures.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots