Skip to content

[RedisEnterprise] Enable TSDB #8584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Nov 28, 2023

Proposed commit message

This PR enables TSDB for RedisEnterprise.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Screenshot 2023-11-28 at 2 37 09 PM

@ritalwar ritalwar requested a review from a team as a code owner November 28, 2023 08:23
@elasticmachine
Copy link

elasticmachine commented Nov 28, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-28T10:02:37.296+0000

  • Duration: 15 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 50.0% (4/8) 👎 -48.276
Lines 100.0% (0/0) 💚 11.644
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar added the enhancement New feature or request label Nov 28, 2023
@ritalwar ritalwar mentioned this pull request Nov 28, 2023
11 tasks
Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observation:

The dashboard visualizations have static intervals as 1m rather than Auto. Is this intentional?

image

@harnish-crest-data
Copy link
Contributor

The visualization Total client connections has an average operation type which seems inappropriate. Can you check if we can use last_value instead of average!

@ritalwar
Copy link
Contributor Author

The dashboard visualizations have static intervals as 1m rather than Auto. Is this intentional?

This was implemented within this PR. For TSDB migration tests, I only verified if visualizations display data correctly or appear distorted. Perhaps @rajvi-patel-22 can provide insights into why "1m" was chosen over "Auto."

@harnish-crest-data
Copy link
Contributor

harnish-crest-data commented Nov 29, 2023

The dashboard visualizations have static intervals as 1m rather than Auto. Is this intentional?

This was implemented within this PR. For TSDB migration tests, I only verified if visualizations display data correctly or appear distorted. Perhaps @rajvi-patel-22 can provide insights into why "1m" was chosen over "Auto."

Okay! I have verified that Rajvi has kept the same behaviour of the Redis enterprise lens migration. Please refer to this link for diff changes.

image

@ritalwar
Copy link
Contributor Author

The visualization Total client connections has an average operation type which seems inappropriate. Can you check if we can use last_value instead of average!

Could you please create a separate issue and add it to the backlog for implementing the right aggregator functions in visualizations?
Let's keep the TSDB enablement separate.

@harnish-crest-data
Copy link
Contributor

The visualization Total client connections has an average operation type which seems inappropriate. Can you check if we can use last_value instead of average!

Could you please create a separate issue and add it to the backlog for implementing the right aggregator functions in visualizations? Let's keep the TSDB enablement separate.

Created a separate issue as per observation: #8603!

@ritalwar ritalwar requested a review from agithomas November 29, 2023 08:23
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ritalwar ritalwar merged commit cb48c85 into elastic:main Nov 29, 2023
@elasticmachine
Copy link

Package redisenterprise - 0.9.0 containing this change is available at https://epr.elastic.co/search?package=redisenterprise

@andrewkroh andrewkroh added the Integration:redisenterprise Redis Enterprise label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:redisenterprise Redis Enterprise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Redis Enterprise] TSDB Enablement
5 participants