Skip to content

[Apache Tomcat]: Improve wording on milliseconds #8701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2023
Merged

[Apache Tomcat]: Improve wording on milliseconds #8701

merged 2 commits into from
Dec 12, 2023

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Dec 12, 2023 •
edited
Loading

This PR proposes a better wording for the field ms.
Relates #123

@alaudazzi alaudazzi added the enhancement New feature or request label Dec 12, 2023
@alaudazzi alaudazzi requested a review from shmsr December 12, 2023 12:20
@alaudazzi alaudazzi self-assigned this Dec 12, 2023
@alaudazzi alaudazzi requested a review from a team as a code owner December 12, 2023 12:20
@alaudazzi alaudazzi added the documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. label Dec 12, 2023
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

elasticmachine commented Dec 12, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-12T12:22:53.018+0000

  • Duration: 26 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 97.531% (79/81) ❕
Lines 82.528% (973/1179) ❕
Conditionals 100.0% (0/0) 💚

@shmsr shmsr changed the title Apache Tomcat - fix wording on milliseconds [Apache Tomcat]: fix wording on milliseconds Dec 12, 2023
@shmsr shmsr changed the title [Apache Tomcat]: fix wording on milliseconds [Apache Tomcat]: Improve wording on milliseconds Dec 12, 2023
@alaudazzi alaudazzi merged commit 3a5470a into elastic:main Dec 12, 2023
@elasticmachine
Copy link

Package apache_tomcat - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shmsr shmsr shmsr approved these changes

Assignees

@alaudazzi alaudazzi

Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. enhancement New feature or request Integration:apache_tomcat Apache Tomcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alaudazzi @elasticmachine @shmsr @andrewkroh