-
Notifications
You must be signed in to change notification settings - Fork 474
[apache_tomcat] Improve access pipeline performance by split grok and switch to dissect #8723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apache_tomcat] Improve access pipeline performance by split grok and switch to dissect #8723
Conversation
🌐 Coverage report
|
🚀 Benchmarks reportTo see the full report comment with |
@SimonAtElastic, Can you please confirm as per your latest commit, the ingest performance is still ~304ms (average)? |
Not exactly, i now average ~0.25ms, so even improved :) I did the seperation of the grok before the dissect and then i got a slight improvement but after the dissect its performing better when combined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Package apache_tomcat - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
Restructuring apache_tomcat.access ingest pipeline to use dissect as first step and split grok into multiple processors to improve perfomance.
On test-env the ingest performance was more den doubled, from ~0.899ms per Document (average) to ~0.253ms per Document (average)