[Azure Logs] Add caller_ip_address field for sign-in logs #8813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checking all other fields like |
🚀 Benchmarks reportTo see the full report comment with |
muthu-mps
changed the title
muthu-mps
reviewed
Jan 5, 2024
| @@ -83,8 +83,7 @@ processors: | |||
| value: '{{{azure.signinlogs.properties.ip_address}}}' | |||
| ignore_empty_value: true | |||
| - set: | |||
| if: ctx?.source?.address == null | |||
| field: source.address | |||
| field: azure.signinlogs.properties.caller_ip_address | |||
There was a problem hiding this comment.
When we add the signinlogs.caller_ip_address into the signinlogs.properties.caller_ip_address what happens with the following use-cases,
- The
callerIpAddressfield is outside the properties when we receive from the Azure. Can we capture this field in the same way? - In a certain scenarios we will get
caller_ip_addressinside the properties as well. How do we handle that?
There was a problem hiding this comment.
- Done, makes sense to keep it as the original.
- I couldn't find a scenario where
caller_ip_addressis inside the properties unless dynamic mapping was applied, which shouldn't be a problem anymore.
Also worth noting that there are no custom log capabilities in Azure for sign-in logs.
muthu-mps
reviewed
Jan 5, 2024
| @@ -93,11 +92,15 @@ processors: | |||
| type: ip | |||
| ignore_missing: true | |||
| ignore_failure: true | |||
| - convert: | |||
| field: azure.signinlogs.properties.caller_ip_address | |||
There was a problem hiding this comment.
Suggested change
| field: azure.signinlogs.properties.caller_ip_address | |
| field: azure.signinlogs.caller_ip_address |
bhapas
reviewed
Jan 5, 2024
packages/azure/data_stream/signinlogs/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
bhapas
approved these changes
Jan 5, 2024
|
Package azure - 1.8.3 containing this change is available at https://epr.elastic.co/search?package=azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add pipeline processing for callerIpAddress field to the Azure sign-in logs.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots