[Cisco FTD] added nullcheck for Network Directionality when zones aren't configured #8883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhapas
reviewed
Jan 15, 2024
packages/cisco_ftd/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
🚀 Benchmarks reportTo see the full report comment with |
bhapas
added
Team:Security-External Integrations
Integration:cisco_ftd
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
bhapas
approved these changes
Jan 15, 2024
|
Package cisco_ftd - 3.0.3 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Hello Folk,
I have added one additional nullcheck for the cisco-ftd integration due to experiencing a bug. In certain configurations, it was possible to experience an processing error, causing the integration to crash out on this part. This additional nullcheck is a quick and easy solution with virtually no impact on performance and causing no breaking changes.
I would also like to recommend to add a pipeline test for the future, to test these changes based on a conversation with @bhapas
Checklist
changelog.ymlfile.