Skip to content

Add Splunk input for application, security and system #890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2021
Merged

Add Splunk input for application, security and system #890

merged 2 commits into from
Apr 12, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 7, 2021 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Screenshots

image

Relates to elastic/security-team#884

Depends on #884

@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@marc-gr marc-gr force-pushed the splunk_system_events branch from 86cb5af to 8c239f1 Compare April 7, 2021 10:07
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #890 updated

  • Start Time: 2021-04-12T07:31:59.581+0000

  • Duration: 9 min 12 sec

  • Commit: a194a0d

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 0
Total 188

Trends 🧪

Image of Build Times

Image of Tests

@marc-gr marc-gr requested a review from leehinman April 7, 2021 10:25
@leehinman
Copy link
Contributor

you ok waiting until we get #884 merged first and then making changes in this PR to match?

@marc-gr
Copy link
Contributor Author

marc-gr commented Apr 8, 2021

you ok waiting until we get #884 merged first and then making changes in this PR to match?

yes, I'll match both this and #821 with the suggested changes from #884

leehinman
leehinman approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr force-pushed the splunk_system_events branch from e865eb5 to e6b180e Compare April 12, 2021 07:16
@marc-gr marc-gr force-pushed the splunk_system_events branch from e6b180e to a194a0d Compare April 12, 2021 07:31
@marc-gr marc-gr merged commit ca6149c into elastic:master Apr 12, 2021
@marc-gr marc-gr deleted the splunk_system_events branch April 12, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marc-gr @elasticmachine @leehinman