Skip to content

[O11y][ActiveMQ] Make GA #8939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2024
Merged

[O11y][ActiveMQ] Make GA #8939

merged 3 commits into from
Feb 5, 2024

Conversation

harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Jan 22, 2024 •
edited
Loading

Proposed commit message

  • This PR make ActiveMQ integration GA.

Author's Checklist

  • Automated Tests / Manual Tests guidelines
  • Timeduration guidelines
  • Field mapping guidelines
  • Document quality check
  • Kibana dashboard guidelines
  • TSDB enablement
  • SDHs check
  • Enhancement Requests check
  • Publish GA checklist summary

Related issues

@harnish-crest-data harnish-crest-data added enhancement New feature or request Integration:activemq ActiveMQ labels Jan 22, 2024
@harnish-crest-data harnish-crest-data self-assigned this Jan 22, 2024
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner January 22, 2024 10:51
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

agithomas
agithomas reviewed Jan 24, 2024
View reviewed changes
packages/activemq/changelog.yml Outdated
changes:
- description: Make ActiveMQ GA.
type: enhancement
link: https://github.com/elastic/integrations/pull/1 #FIX ME
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct PR link

agithomas
agithomas reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muthu-mps , can you please review the GA promotion?

@muthu-mps
Copy link
Contributor

@muthu-mps , can you please review the GA promotion?

Thanks @agithomas - I am already looking into it.

@muthu-mps muthu-mps self-requested a review January 24, 2024 05:31
@agithomas
Copy link
Contributor

As part of the GA enablement, I have created an Author checklist. Reference can be found here. This is based on the GA guidelines document prepared by the team.

@milan-elastic , you may refer to this if needed.

cc @lalit-satapathy , @muthu-mps

@harnish-crest-data
Copy link
Contributor Author

As part of the GA enablement, I have created an Author checklist. Reference can be found here. This is based on the GA guidelines document prepared by the team.

@agithomas Updated it, Thank you!

muthu-mps
muthu-mps approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

ali786XI
ali786XI approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest-data harnish-crest-data merged commit 2f4b072 into elastic:main Feb 5, 2024
@elasticmachine
Copy link

Package activemq - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=activemq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps approved these changes

@ali786XI ali786XI ali786XI approved these changes

@agithomas agithomas Awaiting requested review from agithomas

Assignees

@harnish-crest-data harnish-crest-data

Labels
enhancement New feature or request Integration:activemq ActiveMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ActiveMQ GA
5 participants
@harnish-crest-data @elasticmachine @muthu-mps @agithomas @ali786XI