-
Notifications
You must be signed in to change notification settings - Fork 474
Fixed Grok patterns in apache tomcat integration #9243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When parsing for example a 302 request, the response-bytes are "-" and therefore, the grok processor throwed an error. This should now be fixed.
Fixed ingest errors on non content serving requests
💚 CLA has been signed |
|
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
done @muthu-mps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/test |
|
@muthu-mps done. The problem was, that a non 2XX status code do not give event.outcome as success. I am just not sure why the pipeline does'nt report event.outcome as non-successful on 1XX or 3XX status code response. In my opinion this behaviour should be changed too, so just >=400 is event.outcome failure. |
Thanks for catching the event.outcome parsing issue. We will update the processor to fix this. |
/test |
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
memory |
29411.76 | 18867.92 | -10543.84 (-35.85%) | 💔 |
To see the full report comment with /test benchmark fullreport
💚 Build Succeeded
History
|
|
Package apache_tomcat - 1.3.2 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
When parsing for example a 302 request, the response-bytes are "-" and therefore, the grok processor threw an error. This should now be fixed. --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
When parsing for example a 302 request, the response-bytes are "-" and therefore, the grok processor threw an error. This should now be fixed. --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
When parsing for example a 302 request, the response-bytes are "-" and therefore, the grok processor threw an error. This should now be fixed. --------- Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
Proposed commit message
Access: When parsing for example a 302 request, the response-bytes are "-" and therefore, the grok processor throwed an error. This should now be fixed.
Checklist
changelog.yml
file.