-
Notifications
You must be signed in to change notification settings - Fork 474
[system] Add missing conditional checks to render preserve_original_event
tag when toggled on
#9426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as |
{{#each tags as |tag|}} | ||
- {{tag}} | ||
{{/each}} | ||
{{#if preserve_original_event}} | ||
- preserve_original_event | ||
{{/if}} | ||
{{else}} | ||
{{#if preserve_original_event}} | ||
tags: | ||
- preserve_original_event | ||
{{/if}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this rendering logic on a handlebar playground
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this code does what's been described in the linked issue
preserve_original_event
tag when toggled on
|
💚 Build Succeeded
History
cc @devamanv |
Package system - 1.55.1 containing this change is available at https://epr.elastic.co/search?package=system |
…event` tag when toggled on (#9426)
…event` tag when toggled on (#9426)
…event` tag when toggled on (#9426)
Proposed commit message
The PR contains changes to make sure the
preserve_original_event
tag is rendered without having to add that manually. Complete details have been captured in the related issue. Affected datastreams areapplication
,security
, andsystem
.Checklist
changelog.yml
file.Author's Checklist
Following are some of the sanity checks that must be passed at all times:
How to test this PR locally
elastic-package
to the running Kibana instanceelastic-package install --zip system-1.54.1.zip
1.54.1
, there shouldn't be any errors. If you find any errors while upgrading, please report it by adding a comment to this PR.application
,security
, andsystem
datastream. The preserve_original_event should be rendered when toggled on, and all others tags should render if added in the advanced options at the time of adding the integration.Related issues
Screenshots