cisco_ios: fix handling of timezone configurations #9442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:cisco_ios
The current code assumes that the only way that event.timezone can be set is from within the ingest pipeline. This is not the case since it can be obtained from the system TZ env var. So do not block setting the timezone from the tz_config value if event.timezone is already set, but do set event.timezone to UTC if it is missing as a fallback.
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
cc @efd6 |
|
100.0% Coverage on New Code
0.0% Duplication on New Code
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
Package cisco_ios - 1.26.2 containing this change is available at https://epr.elastic.co/search?package=cisco_ios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The current code assumes that the only way that
event.timezonecan be set is from within the ingest pipeline. This is not the case since it can be obtained from the systemTZenv var. So do not block setting the timezone from thetz_configvalue ifevent.timezoneis already set, but do setevent.timezoneto UTC if it is missing as a fallback.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots