Skip to content

cisco_ios: fix bad auth grok processor handling of missing MD5 sums #9443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2024
Merged

cisco_ios: fix bad auth grok processor handling of missing MD5 sums #9443

merged 2 commits into from
Mar 27, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 26, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:cisco_ios Cisco IOS bugfix Pull request that fixes a bug issue Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Mar 26, 2024
@efd6 efd6 self-assigned this Mar 26, 2024
@efd6 efd6 force-pushed the s4543-cisco_ios branch from 36edd24 to fe22b2e Compare March 26, 2024 01:42
@efd6 efd6 marked this pull request as ready for review March 26, 2024 02:21
@efd6 efd6 requested a review from a team as a code owner March 26, 2024 02:21
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

pkoutsovasilis
pkoutsovasilis approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 force-pushed the s4543-cisco_ios branch from fe22b2e to e202a82 Compare March 26, 2024 02:38
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 requested a review from pkoutsovasilis March 27, 2024 00:14
@efd6 efd6 force-pushed the s4543-cisco_ios branch from 664e1ff to 5ceb899 Compare March 27, 2024 00:26
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 merged commit d1ee786 into elastic:main Mar 27, 2024
@elasticmachine
Copy link

Package cisco_ios - 1.26.3 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

@efd6 efd6 deleted the s4543-cisco_ios branch February 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @pkoutsovasilis