Skip to content

[O11y][Azure] Remove suffix from Compute VMs Overview dashboard #9445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2024
Merged

[O11y][Azure] Remove suffix from Compute VMs Overview dashboard #9445

merged 5 commits into from
Apr 3, 2024

Conversation

harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Mar 26, 2024 •
edited
Loading

  • Enhancement

Proposed commit message

  • According to the issue, need to remove the suffix [Azure Metrics] in two panels which becomes inconsistent looking at the other panel titles.
  • Removed from Markdown panel → Navigation Compute VM Overview
  • Removed from visualization → VM Disk Reads

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshots

Before

image

After

image

@harnish-crest-data harnish-crest-data added the Integration:azure_metrics Azure Resource Metrics label Mar 26, 2024
@harnish-crest-data harnish-crest-data self-assigned this Mar 26, 2024
@harnish-crest-data harnish-crest-data marked this pull request as ready for review March 26, 2024 07:16
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner March 26, 2024 07:16
@elasticmachine
Copy link

elasticmachine commented Mar 26, 2024 •
edited
Loading

🚀 Benchmarks report

Package azure_metrics 👍(2) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
container_service 250000 166666.67 -83333.33 (-33.33%) 💔

To see the full report comment with /test benchmark fullreport

@harnish-crest-data harnish-crest-data changed the title [O11y][Azure] Remove suffix from one panel in Compute VMs Overview dashboard [O11y][Azure] Remove suffix from Compute VMs Overview dashboard Mar 26, 2024
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

kush-elastic
kush-elastic approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

muthu-mps
muthu-mps reviewed Apr 2, 2024
View reviewed changes
packages/azure_metrics/kibana/dashboard/azure_metrics-eb3f05f0-ea9a-11e9-90ec-112a988266d5.json
@@ -42,7 +42,7 @@
"markdown": "### Azure Compute VM \n\n[**Overview**](#/dashboard/azure_metrics-1a151f80-32db-11ea-a83e-25b8612d00cc) | [Guest Windows VM Metrics](#/dashboard/azure_metrics-b6b434c0-feae-11eb-8fff-87871c582eca) | [Guest Linux VM Metrics](#/dashboard/azure_metrics-d8e3c5f0-feaf-11eb-8fff-87871c582eca)",
"openLinksInNewTab": false
},
"title": "Navigation Compute VM Overview [Azure Metrics]",
"title": "Navigation Compute VM Overview",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While performing this change we may need to update the integrations which follows similar patterns,

Screenshot 2024-04-02 at 10 34 33 AM

Integrations with similar naming pattern

  • Storage Metrics
  • Container Instance
  • Container Registry and
  • Container Service

Similar Issue in Other Azure Metrics Integrations

Performed a random check and in the other metrics integrations dashboard and there are similar issue that needs to be addressed. Please find the dashboard screenshot below,

Screenshot 2024-04-02 at 10 45 10 AM

Lets create a separate PR to address this issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muthu-mps, There is already an issue for update the aggregation for Azure metrics. Let me update that issue with this details. Thank you!

@muthu-mps muthu-mps self-requested a review April 2, 2024 05:21
muthu-mps
muthu-mps approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment to address the similar label issue in other Azure Metrics integrations. Otherwise change looks good!

@harnish-crest-data harnish-crest-data mentioned this pull request Apr 2, 2024
Closed
7 tasks
devamanv
devamanv approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zmoog
zmoog approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harnish-crest-data harnish-crest-data merged commit dbf3fc4 into elastic:main Apr 3, 2024
@elasticmachine
Copy link

Package azure_metrics - 1.4.3 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@devamanv devamanv devamanv approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees

@harnish-crest-data harnish-crest-data

Labels
Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][Azure] Remove [Azure Metrics] suffix to the panels titles
6 participants
@harnish-crest-data @elasticmachine @zmoog @devamanv @kush-elastic @muthu-mps