Skip to content

[cisco_ios] Fix handling of ACCESSLOGSP logs #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2024
Merged

[cisco_ios] Fix handling of ACCESSLOGSP logs #9662

merged 3 commits into from
Apr 22, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 22, 2024 •
edited
Loading

https://www.cisco.com/c/en/us/td/docs/ios/12_2sy/system/messages/122sysms/sm2sy05.html (see IPV6_ACL-6)

Proposed commit message

  • The existing pattern for IPACCESSLOGSP and ACCESSLOGSP logs only handles IPACCESSLOGSP. ACCESSLOGSP follows a slightly different pattern. Added a new dissect for this log type.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_ios
elastic-package test

Related issues

  • Relates elastic/sdh-beats#4623

@taylor-swanson
[cisco_ios] Fix handling of ACCESSLOGSP logs
b6407d5 
- The existing pattern for IPACCESSLOGSP and ACCESSLOGSP logs only
handles IPACCESSLOGSP. ACCESSLOGSP follows a slightly different
pattern. Added a new dissect for this log type.
@taylor-swanson taylor-swanson added bug Something isn't working, use only for issues Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 22, 2024
@taylor-swanson taylor-swanson self-assigned this Apr 22, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review April 22, 2024 17:35
@taylor-swanson taylor-swanson requested a review from a team as a code owner April 22, 2024 17:35
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

pkoutsovasilis
pkoutsovasilis approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@taylor-swanson taylor-swanson merged commit 23baa9f into elastic:main Apr 22, 2024
@taylor-swanson taylor-swanson deleted the bug/cisco-ios-igmp branch April 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working, use only for issues Integration:cisco_ios Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team [elastic/sec-deployment-and-devices]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylor-swanson @elasticmachine @pkoutsovasilis