Skip to content

Consolidate content on Azure metrics pages #9674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

alaudazzi
Copy link
Contributor

Proposed commit message

This PR:

  • Removes duplicate and confusing content related to Kibana configurations, authentication, and costs.
  • Adds references to generic instructions documented on the Azure Resource Metrics page.
  • Adds the Requirements and Setup sections to comply with the documentation guidelines.
  • Fixes product names and capitalization

The doc updates impact the following Azure doc pages:

Related issues

@alaudazzi alaudazzi added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. >enhancement labels Apr 23, 2024
@alaudazzi alaudazzi requested review from zmoog and muthu-mps April 23, 2024 08:46
@alaudazzi alaudazzi requested a review from a team as a code owner April 23, 2024 08:46
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only added a couple of capitalization suggestions.

@zmoog
Copy link
Contributor

zmoog commented Apr 23, 2024

LGTM, I only added a couple of capitalization suggestions.

This time, I updated both docs sources and renders, so it should not break the build 🤞

alaudazzi and others added 4 commits April 23, 2024 16:20
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@alaudazzi alaudazzi merged commit 328838e into elastic:main Apr 23, 2024
@elasticmachine
Copy link

Package azure_metrics - 1.6.4 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

gizas pushed a commit that referenced this pull request Apr 26, 2024
* Consolidate content on Azure metrics pages

* Update packages/azure_metrics/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update changelog and manifest

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
@andrewkroh andrewkroh added the Integration:azure_metrics Azure Resource Metrics label Jul 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
* Consolidate content on Azure metrics pages

* Update packages/azure_metrics/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update changelog and manifest

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
* Consolidate content on Azure metrics pages

* Update packages/azure_metrics/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/docs/container_registry.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update packages/azure_metrics/_dev/build/docs/database_account.md

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>

* Update changelog and manifest

---------

Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. >enhancement Integration:azure_metrics Azure Resource Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants