You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's changelog.yml file.
I have verified that Kibana version constraints are current according to guidelines.
Author's Checklist
Mark the password field as secret
Upgrading the package doesn't break the existing integration and metrics still come through
No dashboards are broken
How to test this PR locally
Spin up the Elastic stack and point your elastic-package to the running Kibana instance
Build the package locally and install the package using elastic-package install --zip oracle-1.25.1.zip
Upgrade the integration to the latest version i.e. 1.25.1, there shouldn't be any errors. If you find any errors while upgrading, please report it by adding a comment to this PR.
You should now see separate fields for username and password under advanced options while configuring the Integration for metrics collection
Take a look at the dashboards, they shouldn't be broken and metrics should still be coming in just fine
Are we saying that both formats will work in the latest integration?
@ishleenk17 Yes, I think I have pointed that in my previous comments as well. The Beats code gives preference to params(i.e. username and passwords are part of the DSN itself) if present. That ensures the backwards compatibility and with the new changes, the password is taken as secret which covers the second point.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shmsr
changed the title
Proposed commit message
The PR contains changes to mark the password field as secret.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
elastic-packageto the running Kibana instanceelastic-package install --zip oracle-1.25.1.zip1.25.1, there shouldn't be any errors. If you find any errors while upgrading, please report it by adding a comment to this PR.usernameandpasswordunder advanced options while configuring the Integration for metrics collectionRelated issues
Screenshots
These are after enabling the
PerformanceandMemorymetricsets.Oracle Metrics Overview Dashboard
Performance Metrics Dashboard
Memory Metrics Dashboard