-
Notifications
You must be signed in to change notification settings - Fork 474
[Azure docs] Replace Azure AD with Microsoft Entra ID #9774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zmoog To your question:
This is the Kibana UI, so I guess we need to find a contact on the Kibana team. |
IIRC, Kibana builds the UI elements using the information in the YAML files from the integration source. Let me check! |
Yep, most of the text in the UI elements come from the metadata in the integration YAML files: CleanShot.2024-05-03.at.12.57.23.mp4 |
I will ask the Kibana team. |
It seems we can do this by updating the metadata in the manifest.yml file: diff --git a/packages/azure/manifest.yml b/packages/azure/manifest.yml
index 38c28d051..3e76aa8ed 100644
--- a/packages/azure/manifest.yml
+++ b/packages/azure/manifest.yml
@@ -94,8 +94,8 @@ policy_templates:
size: 5002x2666
type: image/png
- name: adlogs
- title: Azure Active Directory
- description: Azure Directory logs integration
+ title: Microsoft Entra ID
+ description: Collect logs from Microsoft Entra ID (formerly Azure Active Directory) with Elastic Agent.
data_streams:
- auditlogs
- signinlogs
@@ -105,7 +105,7 @@ policy_templates:
- security
inputs:
- type: "azure-eventhub"
- title: "Collect Azure Active Directory logs from Event Hub"
+ title: "Collect Microsoft Entra ID logs from Event Hub"
description: "Collecting Active Directory logs as audit logs and signin logs from Azure instances (input: azure-eventhub)"
input_group: logs
icons: |
@zmoog |
* Microsoft Entra ID | ||
* Azure Monitor | ||
* Spring Apps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetical order?
@efd6, thanks for taking the time to align the text in the diagram! I was about to do the same, but I'll take and commit yours! 😇 |
A couple of diagrams were too broad and were having rendering issues.
Update titles and descriptions, so metadata and UI elements in Kibana are up to date with the rebranding.
Thanks to @efd6 for taking the time to fix the alignment! ❤️
Final result for (1) integration metadata and (2) diagrams. CleanShot.2024-05-06.at.09.54.07.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
Co-authored-by: subham sarkar <sarkar.subhams2@gmail.com>
@alaudazzi - Can we rebuild the package and push the README file changes? |
I made two last changes:
CleanShot.2024-05-07.at.16.05.07.mp4 |
- version: "1.11.4" | ||
changes: | ||
- description: Replace Azure AD with Microsoft Entra ID. | ||
type: bugfix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are rebranding the Azure AD to Microsoft Entra ID
. Can this be an enhancement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are fixing a product name that is now obsolete. If it makes more sense to call it "enhancement", that's fine with me.
@zmoog - This diagram is still referring to Active Directory service. We need to update it to Entra ID.
|
Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>
I found a few other leftovers searching for the following terms:
Can you think of any other case? |
I am able to find the above mentioned terms. We are good! |
@zmoog - The pipeline test data and the generated sample events might have references to the Active Directory. Do you think we need to update the references here as well? IMO, No need to update the test file references. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Yeah, I agree there is no need to update the existing test cases. They were generated when Azure AD was the service name. |
💚 Build Succeeded
History
cc @alaudazzi |
|
Package azure - 1.11.4 containing this change is available at https://epr.elastic.co/search?package=azure |
Microsoft renamed Azure Active Directory (Azure AD) to Microsoft Entra ID.
Refer to https://learn.microsoft.com/en-gb/entra/fundamentals/new-name.
This PR updates the following Elastic integrations doc pages:
Related issues
Closes https://github.com/elastic/integration-docs/issues/325