Skip to content

cloudflare: allow user configuration of results per page #9776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2024
Merged

cloudflare: allow user configuration of results per page #9776

merged 2 commits into from
May 8, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 2, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this May 2, 2024
@efd6 efd6 added enhancement New feature or request Integration:cloudflare Cloudflare (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 2, 2024
@efd6 efd6 force-pushed the s4664-cloudflare branch from 560d0dc to a7e969d Compare May 2, 2024 22:32
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review May 2, 2024 23:01
@efd6 efd6 requested a review from a team as a code owner May 2, 2024 23:01
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

chrisberkhout
chrisberkhout requested changes May 7, 2024
View reviewed changes
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside: the API docs mention "Logpush", but not "Logpull". However, the /client/v4/zones/{zone_identifier}/logs/received endpoint is documented under "Logs Received -> Get logs received".

@efd6 efd6 requested a review from chrisberkhout May 7, 2024 08:12
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 merged commit 6018132 into elastic:main May 8, 2024
@elasticmachine
Copy link

Package cloudflare - 2.25.0 containing this change is available at https://epr.elastic.co/search?package=cloudflare

@efd6 efd6 deleted the s4664-cloudflare branch February 5, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisberkhout chrisberkhout chrisberkhout approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:cloudflare Cloudflare (Community supported) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @chrisberkhout