[cisco_ios] fix timezone with offset parsing #9890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkoutsovasilis
force-pushed
the
pkoutsovasilis/fix_cisco_ios_tz
branch
from
3cf829f to
3ed6d63
Compare
pkoutsovasilis
added
bug
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
jrmolin
approved these changes
May 16, 2024
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
| @@ -187,6 +187,48 @@ | |||
| "preserve_original_event" | |||
| ] | |||
| }, | |||
| { | |||
| "@timestamp": "2024-05-06T16:13:09.123Z", | |||
There was a problem hiding this comment.
I didn't get a chance to drop in a comment before this merged, but this produced the wrong time?
Shouldn't it be 15:13:09 since the original timestamp was 16:13:09 but had a timezone of UTC+1?
There was a problem hiding this comment.
it should! nice catch, another PR is incoming 🥲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR fixes parsing issues with syslog messages that contain a timezone with offset in their timestamp
Checklist
changelog.ymlfile.Author's Checklist
N/A
How to test this PR locally
elastic-package test pipeline -vRelated issues
Screenshots
N/A