-
Notifications
You must be signed in to change notification settings - Fork 474
[Apache.Access] Added response_time in microseconds as a field to apache access data_stream #9913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and re-generated test specs
Please label the PR as an enhancement as I have no permissions to set labels. |
/test |
/test |
🚀 Benchmarks reportTo see the full report comment with |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this PR but we'll need one more round of review from someone in @elastic/obs-infraobs-integrations
@aliabbas-elastic @elastic/obs-infraobs-integrations Are there any update on merging this PR by now? |
@aliabbas-elastic Can u run CI again? I have resolved some merge conflicts in the changelog. Unfortunately this PR ist still not merged. Is there anyone from @elastic/obs-infraobs-integrations I could ping to give some review for this PR? We might need this changes internally soon, thats why this PR should be merged. |
@ishleenk17 As I have seen, you have reviewed the other PR as well. Is it possible for you to review this PR? It is open for quite some time now. |
packages/apache/data_stream/access/elasticsearch/ingest_pipeline/default.yml
Outdated
Show resolved
Hide resolved
/test |
/test |
💚 Build Succeeded
History
cc @Alphayeeeet |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. The changes look good now!
Package apache - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=apache |
Added response_time in microseconds as a field to apache access data_stream
The response_time was added as an optional log parameter in a separate grok pattern, so that it is fully backwards compatible. The new log format, which includes %D was documented in the README as well as the newly added field.
The reason behind this, is to allow response_time to be collected (as in our environment we need it) and therefore a dashboard which uses that could maybe be added in the future.
Checklist
changelog.yml
file.