Skip to content

[Apache.Access] Added response_time in microseconds as a field to apache access data_stream #9913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2024

Conversation

Alphayeeeet
Copy link
Contributor

@Alphayeeeet Alphayeeeet commented May 17, 2024

Added response_time in microseconds as a field to apache access data_stream

The response_time was added as an optional log parameter in a separate grok pattern, so that it is fully backwards compatible. The new log format, which includes %D was documented in the README as well as the newly added field.

The reason behind this, is to allow response_time to be collected (as in our environment we need it) and therefore a dashboard which uses that could maybe be added in the future.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

and re-generated test specs
@Alphayeeeet Alphayeeeet requested a review from a team as a code owner May 17, 2024 10:35
@Alphayeeeet
Copy link
Contributor Author

Please label the PR as an enhancement as I have no permissions to set labels.

@Alphayeeeet Alphayeeeet changed the title Added response_time in microseconds as a field to apache access data_stream [Apache.Access] Added response_time in microseconds as a field to apache access data_stream May 17, 2024
@ali786XI ali786XI added enhancement New feature or request Integration:apache Apache HTTP Server labels May 20, 2024
@ali786XI
Copy link
Contributor

/test

@ali786XI
Copy link
Contributor

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link

@Alphayeeeet Alphayeeeet requested a review from ali786XI May 21, 2024 07:56
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this PR but we'll need one more round of review from someone in @elastic/obs-infraobs-integrations

@Alphayeeeet
Copy link
Contributor Author

@aliabbas-elastic @elastic/obs-infraobs-integrations Are there any update on merging this PR by now?

@Alphayeeeet
Copy link
Contributor Author

@aliabbas-elastic Can u run CI again? I have resolved some merge conflicts in the changelog. Unfortunately this PR ist still not merged. Is there anyone from @elastic/obs-infraobs-integrations I could ping to give some review for this PR? We might need this changes internally soon, thats why this PR should be merged.

@Alphayeeeet Alphayeeeet requested a review from ali786XI June 20, 2024 06:54
@Alphayeeeet
Copy link
Contributor Author

Alphayeeeet commented Jun 20, 2024

@ishleenk17 As I have seen, you have reviewed the other PR as well. Is it possible for you to review this PR? It is open for quite some time now.

@ali786XI
Copy link
Contributor

/test

@ali786XI
Copy link
Contributor

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @Alphayeeeet

Copy link

@Alphayeeeet Alphayeeeet requested a review from ishleenk17 June 20, 2024 12:33
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The changes look good now!

@ishleenk17 ishleenk17 merged commit 746fb3a into elastic:main Jun 20, 2024
5 checks passed
@elasticmachine
Copy link

Package apache - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=apache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:apache Apache HTTP Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants