-
Notifications
You must be signed in to change notification settings - Fork 474
[oracle] Fix used bytes logic #9951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oracle] Fix used bytes logic #9951
Conversation
…tic/integrations into package_oracle_fix_used_bytes
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
|
|
@niraj-elastic Can you share the before and after of the dashboard? Are there changes other than label change in dashboard? |
@@ -1,3 +0,0 @@ | |||
errors: | |||
exclude_checks: | |||
- SVR00002 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More details on this, please.
How is this validation removal being handled in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the datastream.dataset filter is already added to oracle. we don't need to exclude this check. So we can remove this check file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@ishleenk17 The labels are added in this PR which is merged now. we have changed one visualization which has total bytes. I have updated the description with more details of change. |
Thanks for updating the description. It’s much more informative now. |
Package oracle - 1.26.1 containing this change is available at https://epr.elastic.co/search?package=oracle |
Description
The field oracle.tablespace.space.used.bytes is calculated wrongly
Currently we are showing total bytes of tablespace in integration which seems to be incorrect for the field description. This PR will update this query to do following calculation
space.used.bytes
=Total bytes
-Free Bytes
Also fixed visualization related to total.bytes
In visualization "Table space total size" There are two defrent queries are used for counting total bytes.

For NON-TEMP we are showing used+free which is correct.
But for TEPM we are directly showing total bytes. which is incorrect and shows total of all the tablespace.

Checklist
changelog.yml
file.How to test this PR locally
Related issues