[Apache Tomcat] Fix improperly configured fields harvester_limit and close.on_state_change.inactive
#9990
Conversation
niraj-elastic
added
Team:Obs-InfraObs
packages/apache_tomcat/changelog.yml
Outdated
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "1.5.1" | |||
| changes: | |||
| - description: Fix harvester_limit parameter in hbs file. | |||
There was a problem hiding this comment.
| - description: Fix harvester_limit parameter in hbs file. | |
| - description: Fix `harvester_limit` parameter in .hbs file. |
There was a problem hiding this comment.
Also, let's change the PR title to: "Fix improperly configured fields — harvester_limit and close.on_state_change.inactive"?
There was a problem hiding this comment.
Also, I am wondering as we are writing a changelog for our users, do they care if we change something in our *.hbs/ *.yml files? I know we all have been following this. But probably changelog should be more focused on how it changes things for our users.
Like, here with these changes users can now set the fields "Harvest Limit" and "File Handle Closure duration" properly so maybe the changelog should be:
Fix setting the value to fields "Harvest Limit" and "File Handle Closure duration"
But yes, I do not have a strong opinion on this. I'll leave it to you to decide. See: https://docs.elastic.co/integrations/apache_tomcat#changelog
There was a problem hiding this comment.
We can have it as "Fix the Harvester Limit Configuration Parameter"
There was a problem hiding this comment.
I agree with your point. let me change it.
ali786XI
changed the title
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
cache |
22727.27 | 18181.82 | -4545.45 (-20%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
@niraj-elastic Could you also link the related SDH/bug in this PR? |
niraj-elastic
changed the title
harvester_limit and close.on_state_change.inactive
| {{/if}} | ||
| {{#if close.on_state_change.inactive}} | ||
| close.on_state_change.inactive: | ||
| close.on_state_change.inactive: {{close.on_state_change.inactive}} |
There was a problem hiding this comment.
How did we miss this change and did we not test it the last time?
There was a problem hiding this comment.
Not sure, i guess this scenario is not caught in CI as well. Here is PR of the change.
There was a problem hiding this comment.
@ishleenk17 could this have been caught through some pipeline or system tests? Although it's good that we discovered it soon enough, but could this have been avoided?
There was a problem hiding this comment.
@devamanv This PR fixes two issues first is that harvester_limit and close.on_state_change.inactive are not set, and second is that harvester_limit written in new line which is syntax error. The syntax error throws warning shown in description. But when we save this integration for the very first time we don't get this error which is weird. This error is only thrown when the value of these parameters are changed.
|
@niraj-elastic : I just checked and the documentation of harvester_limit is now available after this PR merge in 8.13. |
💚 Build Succeeded
History
|
|
|
Package apache_tomcat - 1.5.1 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
Description
harvester_limitwas configured wrongly inhbs.ymlfile which leads to the following error while saving the integration.This PR is raised to fix the above issue. After fix we are able to save the integration and agent policy is getting updated properly.
Checklist
changelog.ymlfile.How to test this PR locally
Related issues