Skip to content

Add global level data_stream.dataset dashboard filter #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 26, 2024
Merged

Add global level data_stream.dataset dashboard filter #9995

merged 14 commits into from
Jun 26, 2024

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented May 28, 2024 •
edited
Loading

Proposed commit message

Add a global filter to the dashboard and remove the subfilters on the dataset and a global filter on the dataset is introduced. Filters on data_stream.dataset are applied with a phrase type filter on the dataset that is being used in that particular dashboard.

Expect the above mentioned changes done in following selected packages to ease the review

  • prometheus
  • oracle_weblogic
  • containerd
  • azure_application_insights
  • mysql
  • springboot
  • nginx ingress controller
  • nginx
  • istio
  • traefik

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

Screenshot

Prometheus
Before After
prometheus server overview - before prometheus server overview - after
Oracle Weblogic
Deployed application Before Deployed application After
oracle weblogic deployed application - before oracle weblogic deployed application - after
log overview Before log overview After
oracle weblogic logs overview - before oracle weblogic logs overview - after
Threadpool Before Threadpool After
oracle weblogic threadpool - before oracle weblogic threadpool - after
Containerd
Server Before Server After
Before After
containerd overview - before containerd overview - after
Azure Application insights
Before After
App state overview Before App state overview After
Azure Application Insights - Azure Metrics App State Overview - Before Azure Application Insights - Azure Metrics App State Overview - After
Mysql
Logs overview Before Logs overview After
mysql logs overview - before mysql Logs overview - after
Database Before Database After
mysql database overview - before mysql database overview - after
SpringBoot
Access Before Access After
spring boot access logs - before spring boot access logs - after
Audit events Before Audit events After
spring boot audit events - before spring boot audit events - after
Memory and Threads Before Memory and Threads After
spring boot memory and threads - before spring boot memory and threads - after
Overview Before Overview After
spring boot overview - before spring boot overview - after
Nginx ingress controller
Access Before Access After
nginx ingress controller access and error logs - before nginx ingress controller access and error logs - after
Access Before Access After
nginx ingress controller overview - before nginx ingress controller overview - after
Nginx
Log Overview Before Log Overview After
nginx logs overview - before nginx logs overview - after
Access and Error Before Access and Error After
nginx access and error logs - before nginx access and error logs - after
Metrics Overview Before Metrics Overview After
nginx metrics overview - before nginx metrics overview - after
Istio
Overview Before Overview After
metrics istio overview -before metrics istio overview -after
Traffic Before Traffic After
metrics istio traffic -before metrics istio traffic -after
Traefik
Access Overview Before Access After
traefik access - before traefik access - after

@milan-elastic milan-elastic self-assigned this May 28, 2024
@elasticmachine
Copy link

elasticmachine commented May 29, 2024 •
edited
Loading

🚀 Benchmarks report

Package mysql 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
error 26315.79 13698.63 -12617.16 (-47.95%) 💔

Package nginx 👍(0) 💚(1) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
access 2710.03 1569.86 -1140.17 (-42.07%) 💔

Package nginx_ingress_controller 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
error 34482.76 17857.14 -16625.62 (-48.21%) 💔

Package oracle_weblogic 👍(1) 💚(1) 💔(2)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
admin_server 13513.51 9900.99 -3612.52 (-26.73%) 💔
domain 18181.82 12658.23 -5523.59 (-30.38%) 💔

Package spring_boot 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
http_trace 13333.33 10101.01 -3232.32 (-24.24%) 💔

To see the full report comment with /test benchmark fullreport

@milan-elastic milan-elastic mentioned this pull request May 30, 2024
Closed
58 tasks
@milan-elastic milan-elastic marked this pull request as ready for review June 3, 2024 04:44
@milan-elastic milan-elastic requested review from a team as code owners June 3, 2024 04:44
@harnish-crest-data harnish-crest-data self-requested a review June 3, 2024 05:23
harnish-crest-data
harnish-crest-data approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@harnish-crest-data harnish-crest-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@agithomas
Copy link
Contributor

@milan-elastic ,there are a few panels under istio without data. Can this be verified - if there are no datasets missing? I understand that the data is not present in the "before" scenario. However, in such cases, it is best to double-check. Please confirm

@agithomas
Copy link
Contributor

agithomas commented Jun 18, 2024 •
edited
Loading

Kindly check if validations.yml entry needs to be removed for some of the datastreams / packages? Example : nginx_ingresscontroller

@milan-elastic
Copy link
Contributor Author

@milan-elastic ,there are a few panels under istio without data. Can this be verified - if there are no datasets missing? I understand that the data is not present in the "before" scenario. However, in such cases, it is best to double-check. Please confirm

Updated the screenshot and verified the dashboard for istio is working as expected.

@milan-elastic
Copy link
Contributor Author

Kindly check if validations.yml entry needs to be removed for some of the datastreams / packages? Example : nginx_ingresscontroller

I have re-checked all the validations.yml in the packages of this PR and found that azure_application_insights needs to remove the validations.yml file. So I have removed it. Thanks!

agithomas
agithomas approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milan-elastic
Copy link
Contributor Author

@gizas @constanca-m Can you please review and provide code owner approval for istio, containerd and nginx ingress controller packages?

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @milan-elastic

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@milan-elastic milan-elastic merged commit 79e161a into elastic:main Jun 26, 2024
5 checks passed
@elasticmachine
Copy link

Package azure_application_insights - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=azure_application_insights

@elasticmachine
Copy link

Package containerd - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=containerd

@elasticmachine
Copy link

Package istio - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=istio

@elasticmachine
Copy link

Package mysql - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=mysql

@elasticmachine
Copy link

Package nginx - 1.21.0 containing this change is available at https://epr.elastic.co/search?package=nginx

@elasticmachine
Copy link

Package nginx_ingress_controller - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=nginx_ingress_controller

@elasticmachine
Copy link

Package oracle_weblogic - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic

@elasticmachine
Copy link

Package prometheus - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=prometheus

@elasticmachine
Copy link

Package spring_boot - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=spring_boot

@elasticmachine
Copy link

Package traefik - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=traefik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas approved these changes

@agithomas agithomas agithomas approved these changes

@constanca-m constanca-m constanca-m approved these changes

@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes

Assignees

@milan-elastic milan-elastic

Labels
Integration:azure_application_insights Azure Application Insights Metrics Overview Integration:containerd Containerd Integration:istio Istio Integration:mysql MySQL Integration:nginx_ingress_controller Nginx Ingress Controller Logs Integration:nginx Nginx Integration:oracle_weblogic Oracle WebLogic Integration:prometheus Prometheus Integration:spring_boot Spring Boot Integration:traefik Traefik
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@milan-elastic @elasticmachine @agithomas @gizas @constanca-m @harnish-crest-data @andrewkroh