[ML] Track memory usage in CHierarchicalResultsNormalizer #2831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g and limits integration
edsavage
reviewed
Mar 18, 2025
edsavage
approved these changes
Mar 18, 2025
…ment/2244-hierarchical-normalizer
…d include necessary headers
…ed EMPTY_STRING constant
tveasey
reviewed
Mar 19, 2025
…in CHierarchicalResultsNormalizer
tveasey
approved these changes
Mar 19, 2025
tveasey
reviewed
Mar 19, 2025
… CHierarchicalResultsLevelSet
… and CHierarchicalResultsLevelSet
|
|
@wwang500 , this PR should lead to an increase in reported memory usage on jobs with a large number of partitions/influencers. Can you please verify this with the nightly runs? |
valeriy42
added a commit
to valeriy42/ml-cpp
that referenced
this pull request
Mar 21, 2025
This PR makes CHierarchicalResultsNormalizer to track its memory usage. Fixes elastic#2244
valeriy42
added a commit
that referenced
this pull request
Mar 25, 2025
|
Checked the test results from last two weeks, there are no step changes. large jobs or small jobs. i.e., model_bytes from nightly jobs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes CHierarchicalResultsNormalizer to track its memory usage.
Fixes #2244