C++: Remove redundants casts from IR #20154
Draft
+3,075
−3,387
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following snippet:
Because
foo
is aconst
member function there will be aGlvalueConversion
which converts the qualifier from aglval<S>
to aglval<const S>
before it's passed tofoo
. This conversion will generate aConvert
instruction.However, there is very little value in keeping those conversions. In fact, it sometimes makes analysis harder for us. For example, the value number of the qualifier to
foo
(i.e.,s
after the conversion) is different from any other uses ofs
since those uses likely have typeglval<S>
. This fact bit me today!This PR removes these conversions which previously generated a
Convert
instruction, but only modified the specifiers (i.e.,const
ness,volatile
ness, etc.)