`Go: Install current package` doesn't display output like before

[snigle]

What version of Go, VS Code & VS Code Go extension are you using?

Version Information

• Run go version to get version of Go from the VS Code integrated terminal.
  • go version go1.22.2 linux/amd64
• Run gopls -v version to get version of Gopls from the VS Code integrated terminal.
  • golang.org/x/tools/gopls v0.15.3
• Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.
  • 1.88.1
• Check your installed extensions to get the version of the VS Code Go extension
  • v2024.4.1916

• Run Ctrl+Shift+P (Cmd+Shift+P on Mac OS) > Go: Locate Configured Go Tools command.

Tools Configuration

Environment

GOBIN: undefined
toolsGopath:
gopath: /home/user/go/
GOROOT: /usr/local/go
PATH:xxx

Tools

go:	/usr/local/go/bin/go: go version go1.22.2 linux/amd64

gopls:	/home/user/go/bin/gopls	(version: v0.15.3 built with go: go1.22.1)
gotests:	/home/user/go/bin/gotests	(version: v1.6.0 built with go: go1.22.1)
gomodifytags:	/home/user/go/bin/gomodifytags	(version: v1.16.0 built with go: go1.22.1)
impl:	/home/user/go/bin/impl	(version: v1.1.0 built with go: go1.22.1)
goplay:	/home/user/go/bin/goplay	(version: v1.0.0 built with go: go1.22.1)
dlv:	/home/user/go/bin/dlv	(version: v1.22.1 built with go: go1.22.1)
golangci-lint:	/home/user/go/bin/golangci-lint	(version: v1.57.2 built with go: go1.22.1)

GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/user/.cache/go-build'
GOENV='/home/user/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/user/go/pkg/mod'
GONOPROXY='xxx'
GONOSUMDB='xxx'
GOOS='linux'
GOPATH='/home/user/go/'
GOPRIVATE='xxx'
GOPROXY='xxxx'
GOROOT='/home/user/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.linux-amd64'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/user/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.2.linux-amd64/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.2'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='0'
GOMOD='xxx/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2764240210=/tmp/go-build -gno-record-gcc-switches'

Share the Go related settings you have added/edited

"go.testEnvVars": {
        "REGION": "EU",
        "GW_HOST": "",
        "GW_ADDR": "",
        "VAULT_APP_KEY": "",
        "LOCKER_APP_KEY": "",
        "NO_SDEV": "1",
        "TEMPORAL_DEBUG": "1",
        "ULTRON_INFRASTRUCTURE": "preproduction"
    },
    // "go.testTags": "acceptance",
    "go.coverOnSingleTest": true,
    "go.coverOnSingleTestFile": true,
    "go.coverageDecorator": {
        "type": "gutter",
        "coveredHighlightColor": "rgba(64,128,128,0.5)",
        "uncoveredHighlightColor": "rgba(128,64,64,0.25)",
        "coveredGutterStyle": "blockgreen",
        "uncoveredGutterStyle": "slashred"
    },
    "go.testTimeout": "10s",
    "go.delveConfig": {
        "dlvFlags": [
            "--only-same-user=false"
        ],
        "dlvLoadConfig": {
            "maxStringLen": 5000,
            "maxArrayValues": 1000
        }
    },
    "gopls": {
        "build.buildFlags": [
            "-tags",
            "wireinject"
        ]
    },
    "go.lintTool": "golangci-lint",
    "go.lintFlags": [
        // "--fast"
    ],
    "go.lintOnSave": "package",
    "go.gopath": "/home/user/go/",

Describe the bug

When I run Go: Install current package, it does not display me go output in the output view like before.
I need to manually go to it to see when the install is terminated

Steps to reproduce the behavior:

1. Go to main.go
2. Click on F1 -> 'Go: Install current package'
3. No display to say if the installation is done or not

Screenshots or recordings

[findleyr]

Thanks for the report. We're not sure why this regressed, but will investigate.

[h9jiang]

Sorry for the late reply, I was not paying attention to this issue for a while.

With some reading, I think CL change the behavior of the channel. The channel used to be an output channel and now a log output channel. I understand the intention of changing it to log out put channel. The previous channel get cleaned up every time when a new command execution comes in, so all the previous log is deleted.

When using a log output channel, the channel is not opened unless explicitly opened by the user or raised by the extension by calling channel.Show().

I think we are not handling this error properly. Maybe a better way of handling is

If a command succeed, show a pop up in the bottom right

If a command failed show a pop up in the bottom right with a link to "open log"

Hiding the success signal or hiding the error seems wrong to me. What do you think.

@findleyr @madelinekalil

We could make this behavior aligned for all the command execution in vscode-go, create a small package handle this kind of logic.