This repository was archived by the owner on Mar 20, 2024. It is now read-only.
Fix skeptic and enable tests in Travis #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than using a node image and installing rust, we will use the rust images and install node. This makes it easy to test on stable/beta/nightly.
These are failing to build and I don't know why:
```
error[E0277]: expected a `std::ops::Fn<(&mut iron::request::Request<'_, '_>,)>` closure, found `juniper_iron::GraphQLHandler<'_, for<'r, 's, 't0> fn(&'r mut iron::Request<'s, 't0>) -> std::result::Result<(), iron::IronError> {context_factory}, Root, juniper::EmptyMutation<()>, ()>`
--> /var/folders/f3/7xdpkjk508z7b90jfqg1dn2m0000gn/T/rust-skeptic.vXzza3OIPuba/test.rs:34:11
|
34 | mount.mount("/graphql", graphql_endpoint);
| ^^^^^ expected an `Fn<(&mut iron::request::Request<'_, '_>,)>` closure, found `juniper_iron::GraphQLHandler<'_, for<'r, 's, 't0> fn(&'r mut iron::Request<'s, 't0>) -> std::result::Result<(), iron::IronError> {context_factory}, Root, juniper::EmptyMutation<()>, ()>`
|
= help: the trait `for<'r, 's, 't0> std::ops::Fn<(&'r mut iron::request::Request<'s, 't0>,)>` is not implemented for `juniper_iron::GraphQLHandler<'_, for<'r, 's, 't0> fn(&'r mut iron::Request<'s, 't0>) -> std::result::Result<(), iron::IronError> {context_factory}, Root, juniper::EmptyMutation<()>, ()>`
= note: required because of the requirements on the impl of `iron::middleware::Handler` for `juniper_iron::GraphQLHandler<'_, for<'r, 's, 't0> fn(&'r mut iron::Request<'s, 't0>) -> std::result::Result<(), iron::IronError> {context_factory}, Root, juniper::EmptyMutation<()>, ()>`
error[E0277]: expected a `std::ops::Fn<(&mut iron::Request<'_, '_>,)>` closure, found `mount::Mount`
--> /var/folders/f3/7xdpkjk508z7b90jfqg1dn2m0000gn/T/rust-skeptic.vXzza3OIPuba/test.rs:36:17
|
36 | let chain = Chain::new(mount);
| ^^^^^^^^^^ expected an `Fn<(&mut iron::Request<'_, '_>,)>` closure, found `mount::Mount`
|
= help: the trait `for<'r, 's, 't0> std::ops::Fn<(&'r mut iron::Request<'s, 't0>,)>` is not implemented for `mount::Mount`
= note: required because of the requirements on the impl of `iron::Handler` for `mount::Mount`
= note: required by `iron::Chain::new`
error: aborting due to 2 previous errors
```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.