Skip to content

removed incorrect doc/code on individual item resizeHandles #2146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2022
Merged

removed incorrect doc/code on individual item resizeHandles #2146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ Change log

## 7.1.2-dev (TBD)
* fix [#1936](https://github.com/gridstack/gridstack.js/issues/1936) some styles left behind after a drag
* fix [#1842](https://github.com/gridstack/gridstack.js/issues/1842) incorrect doc/partial code on widget resizeHandles

## 7.1.2 (2022-12-29)
* fix [#939](https://github.com/gridstack/gridstack.js/issues/2039) 'prototype' undefined error for dd-gridstack.js
Expand Down
1 change: 0 additions & 1 deletion doc/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,6 @@ The widget can still be dragged or resized by the user.
You need to add `noResize` and `noMove` attributes to completely lock the widget.
- `noResize` - disable element resizing
- `noMove` - disable element moving
- `resizeHandles` - widgets can have their own custom resize handles. For example 'e,w' will make that particular widget only resize east and west. See `resizable: {handles: string}` option
- `id`- (number | string) good for quick identification (for example in change event)
- `content` - (string) html content to be added when calling `grid.load()/addWidget()` as content inside the item
- `subGrid`?: GridStackOptions - optional nested grid options and list of children
Expand Down
2 changes: 0 additions & 2 deletions src/gridstack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,7 +1423,6 @@ export class GridStack {
noMove: 'gs-no-move',
locked: 'gs-locked',
id: 'gs-id',
resizeHandles: 'gs-resize-handles'
};
for (const key in attrs) {
if (node[key]) { // 0 is valid for x,y only but done above already and not in list anyway
Expand All @@ -1450,7 +1449,6 @@ export class GridStack {
node.noResize = Utils.toBool(el.getAttribute('gs-no-resize'));
node.noMove = Utils.toBool(el.getAttribute('gs-no-move'));
node.locked = Utils.toBool(el.getAttribute('gs-locked'));
node.resizeHandles = el.getAttribute('gs-resize-handles');
node.id = el.getAttribute('gs-id');

// remove any key not found (null or false which is default)
Expand Down
2 changes: 0 additions & 2 deletions src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,6 @@ export interface GridStackWidget extends GridStackPosition {
noMove?: boolean;
/** prevents being moved by others during their (default?: undefined = un-constrained) */
locked?: boolean;
/** widgets can have their own custom resize handles. For example 'e,w' will make that particular widget only resize east and west. See `resizable: {handles: string}` option */
resizeHandles?: string;
/** value for `gs-id` stored on the widget (default?: undefined) */
id?: numberOrString;
/** html to append inside as content */
Expand Down