The raiser may get stuck on some element. #3082 #3083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adumesny
reviewed
Jun 30, 2025
| @@ -132,7 +132,7 @@ export class DDResizable extends DDBaseImplement implements HTMLElementExtendOpt | |||
| protected _mouseOver(e: Event): void { | |||
| // console.log(`${count++} pre-enter ${(this.el as GridItemHTMLElement).gridstackNode._id}`) | |||
| // already over a child, ignore. Ideally we just call e.stopPropagation() but see https://github.com/gridstack/gridstack.js/issues/2018 | |||
| if (DDManager.overResizeElement || DDManager.dragElement) return; | |||
| if (DDManager.overResizeElement === this || DDManager.dragElement) return; | |||
| DDManager.overResizeElement = this; | |||
There was a problem hiding this comment.
by doing this you are not clearing the other (if any) element style at line 148 this.el.classList.add('ui-resizable-autohide') so now 2 items are showing resize ?
would be relly helpfull to have a running example to test the issue first...
There was a problem hiding this comment.
this totally breaks nested.html and other nested grid demos. will revert as incorrect fix...
adumesny
added a commit
to adumesny/gridstack.js
that referenced
this pull request
Jul 6, 2025
revert fix gridstack#3082 as that is incorrect fix and breaks nested grids as I suspected.
adumesny
added a commit
that referenced
this pull request
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #3082
The _mouseOut may not clear the overResizeElement properly because there is already another component in the overResizeElement.