Skip to content

Update article.md #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Update article.md #3175

merged 1 commit into from
Sep 21, 2022

Conversation

davidshq
Copy link
Contributor

@davidshq davidshq commented Sep 6, 2022

Minor changes to grammar

Minor changes to grammar
@iliakan
Copy link
Member

iliakan commented Sep 20, 2022

Please explain, is the current grammar wrong or bad?

Also, mentioning "the problem" is a bit clearer than mentioning "constraints", isn't it?

@davidshq
Copy link
Contributor Author

@iliakan - It's a balance between readability and clarity. Problem is a simpler word, constraint more clearly states the type of problem. That said, I don't have a strong opinion on this. If you want to retain problem, I'd change the wording to:

"which do not the same problems as event handlers."

"They are free of such a problem" isn't clear as to what problem exactly is present, the above clarifies while retaining "problems" to maintain readability.

@iliakan iliakan merged commit bbb50e7 into javascript-tutorial:master Sep 21, 2022
@iliakan
Copy link
Member

iliakan commented Sep 21, 2022

Merged, replaced the last phrase with "Developers of web standards understood that long ago and suggested an alternative way of managing handlers using the special methods addEventListener and removeEventListener which aren't bound by such constraint."

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants