Skip to content

Modify have_meta to include an exactly chain #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2020

Conversation

sa73917
Copy link
Contributor

@sa73917 sa73917 commented Jul 10, 2020

What is the current behavior?

the have_meta matcher only provides exact match functionality

What is the new behavior?

the have_meta matcher now operates as an includes matcher, with an optional exactly chain to force an exact match

Checklist

Please make sure the following requirements are complete:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes /
    features)
  • All automated checks pass (CI/CD)

@stas
Copy link
Collaborator

stas commented Jul 10, 2020

Sweet! @sa73917 would you mind updating the README file to include the example with .exactly please? Either way, I'm happy to merge it.

@sa73917
Copy link
Contributor Author

sa73917 commented Jul 10, 2020

Sweet! @sa73917 would you mind updating the README file to include the example with .exactly please? Either way, I'm happy to merge it.

Sorry @stas - was working on about three things at once :-). README now has an exactly example.

@stas stas merged commit 8192567 into jsonapi-rb:master Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants