Remove deprecated ssl setting #11
Conversation
This commit marks the ssl configuration as obsolete. The docs have been updated as well as the tests. This change will be rolled out in a 2.0.0 release which has also been prepped in this work.
donoghuc
force-pushed
the
GH-9-obsolete-ssl-settings
branch
from
a4da16c to
e514cfe
Compare
There was a problem hiding this comment.
On or around line 161, add note/link wrt deprecated settings that have been removed:
"NOTE: As of version 2.0.0 of this plugin, a previously deprecated SSL setting has been removed.
Please check out <<plugins-{type}s-{plugin}-obsolete-options>> for details."
I tweaked the content a bit from the standard to make more sense with only one setting deleted.
ALSO, please check out inline suggestion.
donoghuc
force-pushed
the
GH-9-obsolete-ssl-settings
branch
from
451ac1f to
e514cfe
Compare
|
Please also pick up initial suggestion noted in: #11 (review) GitHub doesn't allow suggestions to sections without changes. They're easy to miss. |
Add a note on where to look for obsolete options, fix whitespace.
|
Sorry, yeah i had an isssue where i committed your suggestion, then when i tried to pull it down locally i ended up on a different local index. I thought i had force pushed it but it was the wrong source<->dest. I think i've got it cleaned up now. Monday problems 😅 |
Remove the deprecated
sslconfig option and document how to replace it withssl_enabled. Prep the 2.0.0 release.