Skip to content

Add CORS middleware to Starlette app for frontend support #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SmartManoj
Copy link

Introduces CORS middleware to the Starlette app instances in FastMCP to allow requests from local web frontends. This enables compatibility with web clients running on localhost and related origins, supporting credentials and common HTTP methods and headers.

Motivation and Context

Fixes #187 (comment)

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Introduces CORS middleware to the Starlette app instances in FastMCP to allow requests from local web frontends. This enables compatibility with web clients running on localhost and related origins, supporting credentials and common HTTP methods and headers.
@SmartManoj SmartManoj requested a review from a team as a code owner July 26, 2025 12:27
@SmartManoj SmartManoj requested a review from dsp-ant July 26, 2025 12:27
Copy link
Member

@dsp-ant dsp-ant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to add this by default. If we do want to allow for certain types of starlette middlewares. We likely want to mimic what FastMCP 2.0 does here. We want support for a proper middleware stack and a default set for auth, with a pre-defined order.

@SmartManoj
Copy link
Author

I don't think we want to add this by default.

Is this wrong?

punkpeye/fastmcp@fe39e7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better CORS defaults for SSE transport
2 participants