Improved supported for ProtectedResourceMetadata #1235
Merged
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcarleton
approved these changes
Aug 4, 2025
|
Can someone please be transparent about what are those sneaky merges? @ihrpr @dsp-ant I've seen a lot of 1-minute PRs pretty frequently with no tests or code quality consideration. This seems too weird. This PR is very short, and I don't see anything bad besides lack of tests, but this has happened a lot. |
|
I will add test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving ProtectedResourceMetadata and feed .well-known/oauth-protected-resource
Motivation and Context
The current ProtectedResourceMetadata was a partial implementation.
I added the full RFC 9728 parameters.
I also improved the create_protected_resource_routes so it is possible to add resource_name (RECOMMENDED in RFC9728) and resource_document, they are of course optional
How Has This Been Tested?
Tested with basic server (and fastmcp)
Breaking Changes
No
Types of changes
Checklist
Additional context