Skip to content

[test] only load reporters when outside of rubymine test runner #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

[test] only load reporters when outside of rubymine test runner #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@

require_relative "instrumentation_test_helper"

Minitest::Reporters.use!(Minitest::Reporters::ProgressReporter.new)
unless ENV["RM_INFO"]
# RubyMine does not support Minitest reporters, so we use the default reporter
Minitest::Reporters.use!(Minitest::Reporters::ProgressReporter.new)
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is concern about the inclusion of the RubyMine-specific environment variable "RM_INFO", which depends on the local environment. It may be worth reconsidering whether Minitest::Reporters configuration is necessary in the first place. If not, removing the use of Minitest::Reporters might be the simpler option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minitest::Reporters is definitely not critical to anything the test suite is doing, it's just an fancy progress bar when running the tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if the appearance of the test progress isn't important, removing it might be the simplest solution.


module ActiveSupport
class TestCase
Expand Down