CSHARP-5688: Bump maxWireVersion for MongoDB 8.3 #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rstam
requested changes
Aug 3, 2025
| @@ -189,7 +194,8 @@ public static ServerVersion ToServerVersion(this int wireVersion) | |||
| WireVersion.Server80 => ServerVersion.Server80, | |||
| WireVersion.Server81 => ServerVersion.Server81, | |||
| WireVersion.Server82 => ServerVersion.Server82, | |||
| _ => throw new ArgumentException($"Invalid write version: {wireVersion}.", nameof(wireVersion)) | |||
| WireVersion.Server83 => ServerVersion.Server83, | |||
| _ => throw new ArgumentException($"Invalid wire version: {wireVersion}.", nameof(wireVersion)) | |||
There was a problem hiding this comment.
I think we need something like a MongoConnectionException and a better error message telling the user what to do, something like:
This version of the driver is not compatible with the version of the server.
We could add "Either use a newer version of the driver or an older version of the server" but I think the problem could happen at the other end also, so that might not be accurate... it could be "either use an older version of the driver or a newer version of the server".
We can probably tell which error message to add based on whether the unknown wire version is too large or too small.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.