-
Notifications
You must be signed in to change notification settings - Fork 13
Search Public Preview - main feature branch #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lsierant
wants to merge
15
commits into
master
Choose a base branch
from
search/public-preview
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17d0fd7
to
a72c572
Compare
# Summary Implements minimum necessary changes to run against newest mongot container built from master: * Workaround for mongot's requirement of password file having owner-only permissions * New config schema structure * Switched default mongot image to ECR * Simulated searchCoordinated role
…string (#273) # Summary This reverts handling replicaSetName from mongot config and adds passing all mongod hosts in the connection string. It is not necessary now to set it, as mongot is connecting in a replicaset mode when there is more than one host passed on connection string. <!-- Enter your issue summary here.--> ## Proof of Work <!-- Enter your proof that it works here.--> <!-- start git-machete generated --> ## Based on PR #229 ## Chain of upstream PRs as of 2025-07-17 * PR #229: `master` ← `search/public-preview` * **PR #273 (THIS ONE)**: `search/public-preview` ← `lsierant/search-multiple-hosts` <!-- end git-machete generated -->
# Summary Expose new TLS capabilities in mongot. ## Proof of Work New [passing](https://spruce.mongodb.com/task/mongodb_kubernetes_e2e_mdb_community_e2e_search_community_tls_patch_39025950721c5e2a2b7e69665729018adceb7ce7_687e2c0229d5cb0007cf2080_25_07_21_12_01_09/tests?execution=0&sorts=STATUS%3AASC) test. ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you checked for release_note changes?
# Summary Handled recent fixes to auth db and replicaset connection in mongot. <!-- start git-machete generated --> ## Chain of upstream PRs as of 2025-07-22 * PR #229: `master` ← `search/public-preview` * **PR #285 (THIS ONE)**: `search/public-preview` ← `lsierant/auth-source` <!-- end git-machete generated -->
# Summary This pull request introduces health check functionality for the `mongot` service, updates readiness and liveness probes, and removes a test decorator for local testing. The changes enhance the monitoring and reliability of the `mongot` service and simplify the test suite. ### Enhancements to `mongot` service health checks: * Added a new constant `MongotDefautHealthCheckPort` set to port `8080` in `mongodbsearch_types.go`. A helper method `GetMongotHealthCheckPort` was also introduced to retrieve this value. * Updated the `buildSearchHeadlessService` function to include a new service port for health checks, using the `GetMongotHealthCheckPort` method. * Modified the `createMongotConfig` function to dynamically set the health check address using the new health check port. ### Readiness and liveness probe improvements: * Introduced constants for probe paths (`SearchLivenessProbePath` and `SearchReadinessProbePath`) in `search_construction.go`. * Replaced the existing readiness probe configuration with new methods `mongotLivenessProbe` and `mongotReadinessProbe`. These methods configure HTTP-based probes using the health check port and paths. ### Test suite simplifications: * Removed the `@skip_if_local` decorator from several `test_om_connectivity` test cases in `om_appdb_scale_up_down.py`, enabling them to run in all environments.
…244) # Summary This pull request introduces validation for unsupported MongoDBSearch image versions and adds a corresponding test case. The key changes include implementing a new validation method, updating the reconciliation logic, and adding constants for unsupported versions. ### Validation for unsupported MongoDBSearch image versions: * **New validation method**: Added `ValidateSearchImageVersion` to `MongoDBSearchReconcileHelper` to check if the specified or container image version matches an unsupported version (`1.47.0`). If so, it returns an error. * **Integration into reconciliation workflow**: Updated the `reconcile` method to invoke `ValidateSearchImageVersion` before proceeding with other validations. * **Constants for unsupported version**: Introduced `unsupportedSearchVersion` and `unsupportedSearchVersionErrorFmt` constants to centralize the unsupported version logic and error formatting. ### Test case for validation: * **New test**: Added `TestMongoDBSearchReconcile_InvalidSearchImageVersion` to validate the error handling for unsupported MongoDBSearch versions. This ensures the reconciliation fails with the appropriate error message. ## Proof of Work Test pass ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [x] Have you checked for release_note changes?
# Summary This makes sure that e2e tests respect the `MDB_SEARCH_COMMUNITY_*` variable overrides in a context. ## Proof of Work [Passing e2e tests](https://spruce.mongodb.com/version/68872f20797f2500073406ff/tasks?page=0&sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC&variant=%5Ee2e_mdb_community%24). ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes?
<!-- start git-machete generated --> # Based on PR #229 ## Chain of upstream PRs as of 2025-07-28 * PR #229: `master` ← `search/public-preview` * **PR #296 (THIS ONE)**: `search/public-preview` ← `lsierant/search-snippets-update` <!-- end git-machete generated --> # Summary <!-- Enter your issue summary here.--> ## Proof of Work <!-- Enter your proof that it works here.--> ## Checklist - [ ] Have you linked a jira ticket and/or is the ticket in the title? - [ ] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes? --------- Co-authored-by: Yavor Georgiev <fealebenpae@users.noreply.github.com> Co-authored-by: Yavor Georgiev <yavor.georgiev@mongodb.com>
MCK 1.2.1 Release NotesOther Changes
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Main feature branch for Search Public Preview release.