-
Notifications
You must be signed in to change notification settings - Fork 13
CLOUDP-331841 - remove the agent matrix work #267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nammn
wants to merge
39
commits into
master
Choose a base branch
from
remove-agent-matrix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d76eda3
to
08c2c49
Compare
3 tasks
nammn
added a commit
that referenced
this pull request
Jul 28, 2025
# Summary - those scripts are required for agent matrix removal. They are placed here - since we overwrite the tag and this would race with the images created in other e2e tests ### Dockerfile updates: * Updated `docker/mongodb-agent-non-matrix/Dockerfile` to copy new scripts (`agent-launcher-shim.sh`, `setup-agent-files.sh`, `dummy-probe.sh`, `dummy-readinessprobe.sh`) into the container at build time. These scripts are placed in `/usr/local/bin` for execution. * Updated `docker/mongodb-agent-non-matrix/Dockerfile.builder` to include the same script files in the build process, ensuring they are available in the image. ### New scripts added: * [`agent-launcher-shim.sh`](diffhunk://#diff-7050c43142cef16fa7268fd7d1356e96bdf5de2c8bc0d050f277babee01a397cR1-R31): A script to initialize the agent launcher by setting up agent files and starting the launcher if the required script is found. * [`setup-agent-files.sh`](diffhunk://#diff-fbe2cd71b8fc58242e04e18562c58b1085f6b059dce42d94a2f4e5cbdf7a3469R1-R95): A script to set up dummy probe scripts initially, wait for an init container to provide real probe and launcher scripts, and replace the dummy scripts with the real ones. * [`dummy-probe.sh`](diffhunk://#diff-ff81b0610fd08dd2d32bcbe72c0d78fb402d5f6dbe8a388bad94c7cdf9b95e3bR1-R5): A dummy liveness probe script that always returns success to keep the container alive during the setup process. * [`dummy-readinessprobe.sh`](diffhunk://#diff-4378f36df04937eb7473771a47dc6ac5a424ec8ffdb171e201b9fc8052a54c26R1-R5): A dummy readiness probe script that always returns a "not ready" status until the real probe script is available. ## Proof of Work - not used anywhere, ci needs to pass - used by this pr (that contains more information on how its used): #267 ## Checklist - [x] Have you linked a jira ticket and/or is the ticket in the title? - [x] Have you checked whether your jira ticket required DOCSP changes? - [ ] Have you checked for release_note changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Database:
from:
to:
AppDB:
from:
to:
Summary Changes
This pull request introduces significant changes to the MongoDB Kubernetes operator, focusing on refactoring, architecture updates, and bug fixes. The changes include removing unused dependencies, improving the handling of static and non-static architectures, and enhancing test coverage. Below is a categorized summary of the most important changes:
Refactoring and Code Simplification
buildDatabaseStatefulSetConfigurationFunction
by introducing shared and architecture-specific modifications. [1] [2]InitDatabaseNonStaticImage
toInitDatabaseImage
inDatabaseStatefulSetOptions
for clarity.Static and Non-Static Architecture Handling
buildStaticArchitecturePodTemplateSpec
andbuildNonStaticArchitecturePodTemplateSpec
) to handle static and non-static architectures, improving modularity and maintainability.AppDbStatefulSet
function to includeopts.InitAppDBImage
when defining init containers, ensuring proper handling of both architectures.Enhancements to StatefulSet and Pod Templates
automationUtilitiesPodTemplateFunc
) to theappDbPodSpec
for managing utility scripts and hooks, along with corresponding volume mounts. [1] [2]AutomationAgentCommand
to include additional startup parameters for better configuration.Proof of Work
Checklist
Reminder (Please remove this when merging)