plugins/yaml-schema-detect: init #3414
Conversation
|
related to: #3328 |
FKouhai
force-pushed
the
add/yaml-schema-detect
branch
from
3ffd052 to
62ed348
Compare
FKouhai
force-pushed
the
add/yaml-schema-detect
branch
from
62ed348 to
3e5fc2f
Compare
| { | ||
| when = !config.plugins.which-key.enable; | ||
| message = '' | ||
| This plugin requires `plugins.which-key` to be enabled |
There was a problem hiding this comment.
I don't see this requirement mentioned on the plugin's README.
There was a problem hiding this comment.
they do not appear to be there, but when I tried running the tests without it it would complain that it needs which-key
There was a problem hiding this comment.
It could be an upstream bug; maybe they have which-key integration that forgets to check it is present before importing it?
There was a problem hiding this comment.
do you think we could merge it? or should I raise an issue upstream about it?(personally speaking im fine having that warning for the users)
There was a problem hiding this comment.
I've opened cwrau/yaml-schema-detect.nvim#6, so let's give upstream a little time to respond.
I don't mind merging if we add references to that issue, but ideally we'd merge once we know what the correct behaviour is.
There was a problem hiding this comment.
I see upstream closed the PR with the additions you mentioned, I guess we can wait for the next round of vimPlugins updates after that I'll rebase and fix the tests, and again thanks Matt :)
There was a problem hiding this comment.
bumping this, updated the test removing which-key and removed the warning that mentioned that the plugin requires it, with that I was able to successfully run the tests I'll wait for #3562 to be merged and then I'll rebase and push the commit again to be ready for a review
No description provided.