Skip to content

colorschemes/gruvbox-material: rename to gruvbox-material-nvim #3558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MattSturgeon
Copy link
Member

@MattSturgeon MattSturgeon commented Jul 15, 2025

  • plugins/deprecation: reformat
  • plugins/deprecation: allow renaming/removing different plugin scopes
  • colorschemes/gruvbox-material: rename to gruvbox-material-nvim

As discussed in #3495 (comment), this is to allow adding a colorschemes.gruvbox-material that uses the non-lua plugin vimPlugins.gruvbox-material.

Included some cleanup and refactoring to enable deprecating colourschemes in plugins/deprecation.nix.

@MattSturgeon MattSturgeon requested review from f4z3r and khaneliman July 15, 2025 01:10
@MattSturgeon MattSturgeon force-pushed the gruvbox-material branch 2 times, most recently from 304dad3 to 22ad69b Compare July 15, 2025 01:57
Copy link
Contributor

@f4z3r f4z3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a Nix language pro, so not sure how much my review is worth. But in regards to updating the colorscheme reference, it makes sense to me. It seems some tests have difficulty finding the colorscheme with the new name though.

This will allow later adding a `gruvbox-material` plugin for the non-lua
plugin.
@chelsea6502
Copy link
Contributor

Thanks Matt! I'll have a go at importing the vimPlugins.gruvbox-material version this weekend.

@MattSturgeon MattSturgeon requested a review from a team July 19, 2025 23:08
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants